fix: add check for codebuild when updating url #12924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0618
approved these changes
Jul 10, 2023
kuhlmanp
approved these changes
Jul 10, 2023
sobolk
reviewed
Jul 10, 2023
Comment on lines
74
to
80
|
|
||
| if (process.env.IS_AMPLIFY_CI) { | ||
| if (process.env.IS_AMPLIFY_CI && process.env.CODEBUILD_SRC_DIR) { | ||
| // use cloudfront distribution for e2e | ||
| url = `https://${process.env.PKG_CLI_CLOUDFRONT_URL}/${version}/${compressedBinaryName}`; | ||
| } else if (process.env.IS_AMPLIFY_CI) { | ||
| url = url.replace('.tgz', `-${getCommitHash()}.tgz`); | ||
| } |
There was a problem hiding this comment.
For future. This should look like
if (IS_AMPLIFY_CI){
if (CODEBUILD) {
} else {
}
}
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
PKG_CLI_CLOUDFRONT_URL is not set in CircleCI. So initially that value was resolving to undefined. Now it will fall into the "else if" and the url will be determined by the hash alone.
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.