Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix commit hash missing on codebuild #12959

Merged
merged 1 commit into from
Jul 18, 2023
Merged

ci: fix commit hash missing on codebuild #12959

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/amplify-cli-npm/binary.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ const getCompressedBinaryUrl = (): string => {
if (process.env.IS_AMPLIFY_CI && process.env.CODEBUILD_SRC_DIR) {
// use cloudfront distribution for e2e
url = `https://${process.env.PKG_CLI_CLOUDFRONT_URL}/${version}/${compressedBinaryName}`;
url = url.replace('.tgz', `-${getCommitHash()}.tgz`);
Comment on lines 77 to +78
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we have to use process.env.PKG_CLI_CLOUDFRONT_URL on codebuild ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its dynamic, based on environment (local/beta/prod)

} else if (process.env.IS_AMPLIFY_CI) {
url = url.replace('.tgz', `-${getCommitHash()}.tgz`);
}
Expand Down
Loading