fix: fix code scanning alerts (#1155)

aws-amplify · Feb 15, 2024 · 575cbcc · 575cbcc
1 parent 3a7c743
commit 575cbcc
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/...i-golden-files/lib/react/forms/datastore-create-form-with-belongs-to/MemberCreateForm.jsx b/...i-golden-files/lib/react/forms/datastore-create-form-with-belongs-to/MemberCreateForm.jsx
@@ -50,7 +50,7 @@ function ArrayField({
     setSelectedBadgeIndex(undefined);
   };
   const addItem = async () => {
-    if ((currentFieldValue !== undefined || currentFieldValue !== null || currentFieldValue !== '') && !hasError) {
+    if ((currentFieldValue !== undefined || currentFieldValue !== '') && !hasError) {
       const newItems = [...items];
       if (selectedBadgeIndex !== undefined) {
         newItems[selectedBadgeIndex] = currentFieldValue;

diff --git a/...les/lib/react/forms/datastore-update-form-with-has-many-relationship/SchoolUpdateForm.jsx b/...les/lib/react/forms/datastore-update-form-with-has-many-relationship/SchoolUpdateForm.jsx
@@ -44,7 +44,7 @@ function ArrayField({
     setSelectedBadgeIndex(undefined);
   };
   const addItem = async () => {
-    if ((currentFieldValue !== undefined || currentFieldValue !== null || currentFieldValue !== '') && !hasError) {
+    if ((currentFieldValue !== undefined || currentFieldValue !== '') && !hasError) {
       const newItems = [...items];
       if (selectedBadgeIndex !== undefined) {
         newItems[selectedBadgeIndex] = currentFieldValue;

diff --git a/commitlint.config.js b/commitlint.config.js
@@ -5,7 +5,7 @@ const {
 module.exports = {
   extends: ['@commitlint/config-conventional', '@commitlint/config-lerna-scopes'],
   rules: {
-    'scope-enum': async (context) => [2, 'always', [...(await getPackages(context)), 'release', 'deps']],
+    'scope-enum': async (context) => [2, 'always', [...(await getPackages(context)), 'release', 'deps', 'deps-dev']],
     'header-max-length': [2, 'always', 200],
   },
 };