Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move golden files out of workspaces #1149

Merged
merged 1 commit into from
Feb 14, 2024
Merged

chore: move golden files out of workspaces #1149

merged 1 commit into from
Feb 14, 2024

Conversation

zchenwei
Copy link
Contributor

@zchenwei zchenwei commented Feb 14, 2024

Problem

Move golden files out of workspaces and delete package.json and package-lock.json in it.

Automated tests

  • Unit tests added/updated
  • E2E tests added/updated
  • N/A - (provide a reason)
  • deferred - (provide GitHub issue for tracking)

Housekeeping

  • No non-essential console logs
  • All new files contain license notice

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@zchenwei zchenwei requested a review from a team as a code owner February 14, 2024 18:31
Copy link
Contributor

@jacoblogan jacoblogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zchenwei zchenwei merged commit 3f4216e into main Feb 14, 2024
11 checks passed
@zchenwei zchenwei deleted the move-goldenfile branch February 14, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants