-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ModelIdentifier for all Java models #612
Conversation
Marking as draft until improvements are fully staged in Amplify Android. |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #612 +/- ##
==========================================
- Coverage 85.92% 85.91% -0.01%
==========================================
Files 152 152
Lines 7493 7492 -1
Branches 1959 1958 -1
==========================================
- Hits 6438 6437 -1
Misses 962 962
Partials 93 93
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Description of changes
If CPK flag is enabled:
resolveIdentifier
will only return the ModelIdentifier if cpk + sort keyresolveIdentifier
as it is only intended to be used internally in AmplifyAll changes are additive (non-breaking)
Description of how you validated changes
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.