fix: support key directive in model introspection schema gen #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alharris-at
force-pushed
the
bug-fix-in-v1
branch
from
d0e3681
to
bf34d16
Compare
alharris-at
force-pushed
the
bug-fix-in-v1
branch
from
bf34d16
to
38c1c9c
Compare
phani-srikar
approved these changes
Jul 14, 2023
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #628 +/- ##
==========================================
- Coverage 85.93% 84.43% -1.51%
==========================================
Files 152 152
Lines 7489 6437 -1052
Branches 1956 1384 -572
==========================================
- Hits 6436 5435 -1001
+ Misses 960 902 -58
- Partials 93 100 +7
... and 115 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dpilch
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Today, a key directive in GraphQLV1 that uses a belongsTo FK will cause the model introspection schema to fail. This addresses that issue, by no longer removing the field hardcoded by 'id' but instead checking if it's the model pk.
Issue #, if available
N/A - ticket
Description of how you validated changes
Added unit tests which previously failed, added v2 test for comparison of behavior.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.