Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate multiple swift files #718

Merged
merged 1 commit into from
Sep 26, 2023
Merged

fix: generate multiple swift files #718

merged 1 commit into from
Sep 26, 2023

Conversation

dpilch
Copy link
Member

@dpilch dpilch commented Sep 26, 2023

Description of changes

Generate multiple Swift type files. The separate files are for each GraphQL statement file. The multiple type files need the names of the GraphQL statements files in order to generate with the correct names.

This leaves us a few options for the queries arg.

  1. [fileContents: string, filename: string][]
  2. Source[] (from graphql package).
  3. Type union of the current type (string) and one of the two above options.

I chose string | Source[] for this PR, but I don't have strong feelings on the end direction.

Issue #, if available

#711

Description of how you validated changes

  • Unit tests
  • Manual tests

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dpilch dpilch requested review from a team as code owners September 26, 2023 19:04
@dpilch dpilch merged commit 1e484af into main Sep 26, 2023
3 of 4 checks passed
@dpilch dpilch deleted the mult-swift-files branch September 26, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants