Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace windows path separator with posix #727

Closed
wants to merge 1 commit into from

Conversation

dpilch
Copy link
Member

@dpilch dpilch commented Oct 2, 2023

Description of changes

See https://github.com/aws-amplify/amplify-cli/issues/13289 for details. path.relative behaves differently on windows. https://nodejs.org/api/path.html#pathrelativefrom-to

This results in the generated path being invalid syntax in TypeScript/JavaScript.

This change replaces the current OS environment path separator (path.sep) with the posix path separator (path.posix.sep).

Issue #, if available

https://github.com/aws-amplify/amplify-cli/issues/13289

Description of how you validated changes

Nothing yet 😬

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • Breaking changes to existing customers are released behind a feature flag or major version update
  • Changes are tested using sample applications for all relevant platforms (iOS/android/flutter/Javascript) that use the feature added/modified

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dpilch dpilch requested a review from a team as a code owner October 2, 2023 16:29
@dpilch dpilch mentioned this pull request Oct 2, 2023
3 tasks
@dpilch dpilch closed this Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants