Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unnecessary deps, including fixture dependencies #731

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

alharris-at
Copy link
Contributor

@alharris-at alharris-at commented Oct 2, 2023

Description of changes

Removing fixtures from our eslint rules, which were causing us to unnecessarily depend on aws-sdk, amplify js libs, and something else.

I also refreshed the yarn.lock file.

Issue #, if available

N/A

Description of how you validated changes

Unit + E2E Tests

Checklist

  • PR description included
  • yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@alharris-at alharris-at requested a review from a team as a code owner October 2, 2023 22:09
phani-srikar
phani-srikar previously approved these changes Oct 2, 2023
dpilch
dpilch previously approved these changes Oct 2, 2023
.eslintrc.js Outdated Show resolved Hide resolved
@alharris-at alharris-at merged commit 7d71ee0 into main Oct 2, 2023
3 of 4 checks passed
@alharris-at alharris-at deleted the move-deps-to-dev-deps branch October 2, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants