Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: many to many auth #748

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

olliethedev
Copy link
Contributor

@olliethedev olliethedev commented Oct 20, 2023

Description of changes

This PR addresses the omission of @auth directive attributes in the generated schema for @manyToMany relations, specifically impacting how Datastore performs calls to the joint tables. By ensuring accurate propagation and merging of the @auth directives and their rules to the joint table model, this PR facilitates correct authorization information being available for Datastore operations on the joint tables.

Issue

#473

Description of how you validated changes

  • Unit tests
  • Test in sample app using amplify-dev

Checklist

  • PR description included
  • yarn test passes
  • Changes are tested using sample applications for all relevant platforms (iOS/android/flutter/Javascript) that use the feature added/modified

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@olliethedev olliethedev requested a review from a team as a code owner October 20, 2023 19:15
@olliethedev olliethedev changed the title Fix many to many auth Fix: many to many auth Oct 20, 2023
@AaronZyLee AaronZyLee merged commit dc5ac44 into aws-amplify:main Jan 3, 2024
3 checks passed
@phani-srikar phani-srikar mentioned this pull request Jan 26, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants