test: build type and graphql statement generation #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpilch
commented
Nov 20, 2023
packages/amplify-codegen-e2e-tests/src/__tests__/build-app-swift.test.ts
Show resolved
Hide resolved
| await apiGqlCompile(projectRoot); | ||
| await generateModels(projectRoot); | ||
| await generateStatementsAndTypes(projectRoot); | ||
| writeFileSync(path.join(projectRoot, statementsDir, 'mutations.graphql'), 'foo\nbar'), |
There was a problem hiding this comment.
nit: comma at the end to ;
| await generateStatementsAndTypes(projectRoot); | ||
| writeFileSync(path.join(projectRoot, statementsDir, 'mutations.graphql'), 'foo\nbar'), | ||
| expect(() => parse(readFileSync(path.join(projectRoot, statementsDir, 'mutations.graphql'), 'utf8'))).toThrowError(); | ||
| await androidBuild(projectRoot, { ...config }); |
There was a problem hiding this comment.
this build is expected to fail right? Since we're adding invalid GQL.
There was a problem hiding this comment.
The android compilation won't fail in this case because the GraphQL statements are generated with raw GraphQL syntax. Line 108 covers the failure. Line 109 isn't really needed in this case.
There was a problem hiding this comment.
If it's not needed, is there a reason we don't just remove it?
phani-srikar
approved these changes
Nov 23, 2023
palpatim
approved these changes
Nov 27, 2023
sundersc
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Test building an app after generating graphql statements and types.
Issue #, if available
N/A
Description of how you validated changes
Run the tests: https://us-east-1.console.aws.amazon.com/codesuite/codebuild/594813022831/projects/amplify-codegen-e2e-workflow/batch/amplify-codegen-e2e-workflow:0a304923-d204-44dd-9a2c-42e65de590d2?region=us-east-1
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.