feat: set correct association with references #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atierian
reviewed
Mar 21, 2024
packages/appsync-modelgen-plugin/src/scalars/supported-directives.ts
Outdated
Show resolved
Hide resolved
atierian
previously approved these changes
Mar 21, 2024
palpatim
reviewed
Apr 10, 2024
...s/appsync-modelgen-plugin/src/__tests__/visitors/appsync-model-introspection-visitor.test.ts
Outdated
Show resolved
Hide resolved
packages/appsync-modelgen-plugin/src/__tests__/visitors/appsync-visitor.test.ts
Outdated
Show resolved
Hide resolved
| targetName: targetNames[0], | ||
| targetNames, | ||
| reference, |
There was a problem hiding this comment.
naming nit for the variable and the CodeGenFieldConnection type: useReferences or isUsingReferences?
packages/appsync-modelgen-plugin/src/utils/process-connections-v2.ts
Outdated
Show resolved
Hide resolved
packages/appsync-modelgen-plugin/src/utils/process-connections.ts
Outdated
Show resolved
Hide resolved
palpatim
approved these changes
Apr 10, 2024
atierian
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Update associations to use custom field names when using
references. Previously associations to used the implicit names whenreferenceswere set.See #806 for spec.
Codegen Paramaters Changed or Added
N/A
Issue #, if available
N/A
Description of how you validated changes
Checklist
yarn testpassespath) behave differently on windows.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.