Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not remove belongsTo target names when using references #814

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

dpilch
Copy link
Member

@dpilch dpilch commented Apr 19, 2024

Description of changes

  • do not remove belongsTo target names when using references on native

Codegen Paramaters Changed or Added

N/A

Issue #, if available

N/A

Description of how you validated changes

  • Unit tests

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dpilch dpilch marked this pull request as ready for review April 19, 2024 16:13
@dpilch dpilch requested a review from a team as a code owner April 19, 2024 16:13
@dpilch dpilch enabled auto-merge (squash) April 19, 2024 16:13
});
});

test('hasMany with sortKeyFields on primary key', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and for other platforms: we should probably add one for hasOne with sortKeyFields as well, just to be safe?

@dpilch dpilch merged commit de394dd into feature/gen2-release Apr 19, 2024
3 of 4 checks passed
@dpilch dpilch deleted the include-target-name branch April 19, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants