Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing closing parens on swift hasMany #835

Merged
merged 1 commit into from
May 6, 2024
Merged

fix: add missing closing parens on swift hasMany #835

merged 1 commit into from
May 6, 2024

Conversation

dpilch
Copy link
Member

@dpilch dpilch commented May 6, 2024 •
edited
Loading

Description of changes

  • add missing closing parens on swift hasMany when using references.

Codegen Paramaters Changed or Added

N/A

Issue #, if available

N/A

Description of how you validated changes

  • Unit tests
  • E2E tests

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Changes are tested using sample applications for all relevant platforms (iOS/android/flutter/Javascript) that use the feature added/modified

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dpilch dpilch marked this pull request as ready for review May 6, 2024 21:16
@dpilch dpilch requested a review from a team as a code owner May 6, 2024 21:16
@dpilch dpilch enabled auto-merge (squash) May 6, 2024 21:34
@dpilch dpilch merged commit cfd4c2b into main May 6, 2024
4 of 5 checks passed
@dpilch dpilch deleted the fix-closing-parens branch May 6, 2024 21:56
@dpilch dpilch mentioned this pull request May 7, 2024
Merged
2 tasks
@dpilch dpilch mentioned this pull request Oct 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palpatim palpatim palpatim approved these changes

@phani-srikar phani-srikar phani-srikar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dpilch @palpatim @phani-srikar