ci: add deprecate workflow #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpilch
force-pushed
the
deprecate-workflow
branch
from
942b3a6
to
c422e88
Compare
dpilch
force-pushed
the
deprecate-workflow
branch
from
c422e88
to
176a9ef
Compare
dpilch
force-pushed
the
deprecate-workflow
branch
from
0d52c50
to
b678d29
Compare
sundersc
reviewed
May 17, 2024
Comment on lines
+26
to
+28
| DEPRECATION_MESSAGE=$1 | ||
| SEARCH_FOR_RELEASE_STARTING_FROM=$2 | ||
| USE_NPM_REGISTRY=$3 |
There was a problem hiding this comment.
Are these the arguments to yarn trigger-deprecate-release script?
sundersc
reviewed
May 17, 2024
package.json
Outdated
| "verify-dependency-licenses-extract": "yarn extract-dependency-licenses && ./scripts/verify-dependency-licenses.sh" | ||
| "verify-dependency-licenses-extract": "yarn extract-dependency-licenses && ./scripts/verify-dependency-licenses.sh", | ||
| "deprecate": "ts-node scripts/deprecate_release.ts", | ||
| "postinstall": "echo 'export default [' > scripts/components/private_packages.ts && grep -l packages/*/package.json -e '\"private\": \"\\?true\"\\?' | xargs cat | jq .name | tr -s '\\n' ',' >> scripts/components/private_packages.ts && echo '];' >> scripts/components/private_packages.ts" |
There was a problem hiding this comment.
Is it possible to move this to its own script file? This feels too complex to live in-line on package.json file.
palpatim
previously approved these changes
May 17, 2024
palpatim
approved these changes
May 20, 2024
sundersc
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Copy workflow from aws-amplify/amplify-category-api#2532
Description of how you validated changes
Dry run in personal account.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.