Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add deprecate workflow #846

Merged
merged 6 commits into from
May 20, 2024
Merged

ci: add deprecate workflow #846

merged 6 commits into from
May 20, 2024

Conversation

dpilch
Copy link
Member

@dpilch dpilch commented May 17, 2024

Description of changes

Copy workflow from aws-amplify/amplify-category-api#2532

Description of how you validated changes

Dry run in personal account.

yarn trigger-deprecate-release "contains regression" cbbb1d39c326c4097d9ff06556d6ddd337662d22 false
Moving dist tag "latest" to release tag @aws-amplify/appsync-modelgen-plugin@2.12.0
--
54 | +latest: @aws-amplify/appsync-modelgen-plugin@2.12.0
55 | Done!
56 |  
57 | Moving dist tag "latest" to release tag @aws-amplify/graphql-generator@0.4.1
58 | +latest: @aws-amplify/graphql-generator@0.4.1
59 | Done!
60 |  
61 | Moving dist tag "latest" to release tag amplify-codegen@4.9.1
62 | +latest: amplify-codegen@4.9.1
63 | Done!
64 |  
65 | Deprecating package version @aws-amplify/appsync-modelgen-plugin@2.12.1
66 | Done!
67 |  
68 | Deprecating package version @aws-amplify/graphql-generator@0.4.2
69 | Done!
70 |  
71 | Deprecating package version amplify-codegen@4.9.2
72 | Done!

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dpilch dpilch marked this pull request as ready for review May 17, 2024 22:17
@dpilch dpilch requested review from a team as code owners May 17, 2024 22:17
Comment on lines +26 to +28
DEPRECATION_MESSAGE=$1
SEARCH_FOR_RELEASE_STARTING_FROM=$2
USE_NPM_REGISTRY=$3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these the arguments to yarn trigger-deprecate-release script?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

package.json Outdated
"verify-dependency-licenses-extract": "yarn extract-dependency-licenses && ./scripts/verify-dependency-licenses.sh"
"verify-dependency-licenses-extract": "yarn extract-dependency-licenses && ./scripts/verify-dependency-licenses.sh",
"deprecate": "ts-node scripts/deprecate_release.ts",
"postinstall": "echo 'export default [' > scripts/components/private_packages.ts && grep -l packages/*/package.json -e '\"private\": \"\\?true\"\\?' | xargs cat | jq .name | tr -s '\\n' ',' >> scripts/components/private_packages.ts && echo '];' >> scripts/components/private_packages.ts"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to move this to its own script file? This feels too complex to live in-line on package.json file.

palpatim
palpatim previously approved these changes May 17, 2024
@dpilch dpilch enabled auto-merge (squash) May 20, 2024 14:07
@dpilch dpilch merged commit 72e714d into main May 20, 2024
3 of 4 checks passed
@dpilch dpilch deleted the deprecate-workflow branch May 20, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants