fix(amplify-codegen): support multiple indexes on the same field in introspection schema #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntrospection schema
dpilch
approved these changes
Sep 17, 2024
| }, {} as Record<string, CodeGenDirective[]>); | ||
|
|
||
| const keyList: CodeGenDirective[] = []; | ||
| Object.entries(indexMap).forEach(([fieldName, directives]) => { |
There was a problem hiding this comment.
nit: Why change this from a map to a forEach?
There was a problem hiding this comment.
.map returns a new array, whereas .forEach doesn't return anything. Since the refactored code doesn't rely on the returned array, .forEach is a better fit here.
palpatim
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes a bug where multiple indexes on a field is not correctly represented on the generated model introspection schema.
Codegen Paramaters Changed or Added
No.
Issue #, if available
Fixes aws-amplify/amplify-category-api#2815
Description of how you validated changes
Note
Manual testing: I've tested the fix on a sample Gen2 app using NPM overrides pointing to the local packaged module.
Checklist
yarn testpassespath) behave differently on windows.type,input,enum,interface,unionand scalar types.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.