fix(conversation): prefix supporting types with AmplifyAI #907
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs
Problem
Conversation routes add several GraphQL types (type, input, enum, interface) to the GraphQL schema. These types are only added if a conversation route is defined via the
@conversation
directive and are conversation route agnostic (only added once per GraphQL schema regardless of the amount of conversation routes).These types have generic enough names that they can conflict with customer defined types.
GraphQL Types
Description of changes
Prefixes all supporting types with
"AmplifyAI"
.The supporting types themselves are defined in
data-schema
(see related PR aws-amplify/amplify-data#395).This PR updates appsync-modelgen-plugin as a consumer of these types. This is necessary to ensure the MIS is correct because the
@model
s generated by the conversation transformer have fields using the supporting types.Codegen Paramaters Changed or Added
N/A
Issue #, if available
See aws-amplify/amplify-ui#5773 (comment)
Description of how you validated changes
Mix of manual and automated testing through tagged releases:
Checklist
yarn test
passesTests are changed or addedRelevant documentation is changed or added (and PR referenced)Breaking changes to existing customers are released behind a feature flag or major version updateChanges are tested on windows. Some Node functions (such aspath
) behave differently on windows.type
,input
,enum
,interface
,union
and scalar types.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.