Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api)!: Model .fromJson() Refactor #4665

Merged
merged 8 commits into from
Apr 23, 2024
Merged

Conversation

Equartey
Copy link
Member

@Equartey Equartey commented Apr 4, 2024

Issue #, if available:
#816

Description of changes:
Flattens the nested data structure of serializedData across the method channel and the .fromJson() method found on codegen models. This PR is to be paired with changes in aws-amplify/amplify-codegen#593

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Equartey Equartey requested a review from a team as a code owner April 4, 2024 19:11
@Equartey Equartey force-pushed the chore/api-from-json-refactor branch 2 times, most recently from 76e8dbf to 77909a9 Compare April 5, 2024 19:37
@Equartey Equartey changed the title chore(api): Model .fromJson() Refactor chore(api)!: Model .fromJson() Refactor Apr 8, 2024
@Equartey Equartey force-pushed the chore/api-from-json-refactor branch from 5981c2c to 2e5e0e3 Compare April 15, 2024 19:07
@Equartey Equartey force-pushed the chore/api-from-json-refactor branch from dbbb859 to 810685b Compare April 18, 2024 16:03
Jordan-Nelson
Jordan-Nelson previously approved these changes Apr 19, 2024
@@ -44,5 +44,15 @@ end
post_install do |installer|
installer.pods_project.targets.each do |target|
flutter_additional_ios_build_settings(target)
target.build_configurations.each do |config|
# Workaround for: https://github.com/flutter/flutter/issues/126449
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: Is this still needed? The GH issue linked says it was resolved in flutter v3.10

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, no it should be removed.

NikaHsn
NikaHsn previously approved these changes Apr 19, 2024
@Equartey Equartey dismissed stale reviews from NikaHsn and Jordan-Nelson via 9392c13 April 22, 2024 16:22
@Equartey Equartey merged commit 365c5fb into main Apr 23, 2024
157 checks passed
@Equartey Equartey deleted the chore/api-from-json-refactor branch April 23, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants