-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(api): app life cycle 'resume' triggers web socket reconnection #5567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Equartey
reviewed
Oct 17, 2024
Equartey
reviewed
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and its working great. Left two small nits, otherwise looks good! Nice work
packages/api/amplify_api_dart/lib/src/graphql/web_socket/types/web_socket_event.dart
Outdated
Show resolved
Hide resolved
tyllark
changed the title
Fix/app life cycle datastore websockets
fix(api): app life cycle datastore websockets
Oct 17, 2024
ekjotmultani
previously approved these changes
Oct 17, 2024
Equartey
changed the title
fix(api): app life cycle datastore websockets
fix(api): app life cycle 'resume' triggers web socket reconnection
Oct 18, 2024
Equartey
reviewed
Oct 18, 2024
packages/api/amplify_api_dart/lib/src/graphql/web_socket/blocs/web_socket_bloc.dart
Outdated
Show resolved
Hide resolved
packages/api/amplify_api_dart/lib/src/graphql/web_socket/blocs/web_socket_bloc.dart
Outdated
Show resolved
Hide resolved
packages/api/amplify_api_dart/lib/src/graphql/web_socket/blocs/web_socket_bloc.dart
Show resolved
Hide resolved
packages/api/amplify_api_dart/test/web_socket/web_socket_bloc_test.dart
Outdated
Show resolved
Hide resolved
Equartey
approved these changes
Oct 18, 2024
Equartey
approved these changes
Oct 18, 2024
ekjotmultani
approved these changes
Oct 18, 2024
Equartey
pushed a commit
that referenced
this pull request
Oct 21, 2024
…5567) * fix(api): Reconnect WebSocket when resuming app from a paused state
Equartey
added a commit
that referenced
this pull request
Oct 21, 2024
Version successfully bumped chore(version): Bump version ### Features - feat(api): move App Sync subscription headers to protocol ([#5301](#5301)) - feat(authenticator): export unmet password requirements ([#5437](#5437)) ### Fixes - fix(api): Reconnect WebSocket when resuming app from a paused state ([#5567](#5567)) Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Equartey
added a commit
that referenced
this pull request
Oct 21, 2024
### Features - feat(api): move App Sync subscription headers to protocol ([#5301](#5301)) - feat(authenticator): export unmet password requirements ([#5437](#5437)) ### Fixes - fix(api): Reconnect WebSocket when resuming app from a paused state ([#5567](#5567)) Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Equartey
pushed a commit
that referenced
this pull request
Oct 21, 2024
…5567) * fix(api): Reconnect WebSocket when resuming app from a paused state
Equartey
added a commit
that referenced
this pull request
Oct 21, 2024
### Features - feat(api): move App Sync subscription headers to protocol ([#5301](#5301)) - feat(authenticator): export unmet password requirements ([#5437](#5437)) ### Fixes - fix(api): Reconnect WebSocket when resuming app from a paused state ([#5567](#5567)) Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Equartey
pushed a commit
that referenced
this pull request
Oct 22, 2024
…5567) * fix(api): Reconnect WebSocket when resuming app from a paused state
Equartey
added a commit
that referenced
this pull request
Oct 22, 2024
### Features - feat(api): move App Sync subscription headers to protocol ([#5301](#5301)) - feat(authenticator): export unmet password requirements ([#5437](#5437)) ### Fixes - fix(api): Reconnect WebSocket when resuming app from a paused state ([#5567](#5567)) Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Equartey
added a commit
that referenced
this pull request
Oct 22, 2024
### Features - feat(api): move App Sync subscription headers to protocol ([#5301](#5301)) - feat(authenticator): export unmet password requirements ([#5437](#5437)) ### Fixes - fix(api): Reconnect WebSocket when resuming app from a paused state ([#5567](#5567)) Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Equartey
added a commit
that referenced
this pull request
Oct 23, 2024
chore(version): Bump version ### Features - feat(api): move App Sync subscription headers to protocol ([#5301](#5301)) - feat(authenticator): export unmet password requirements ([#5437](#5437)) ### Fixes - fix(api): Reconnect WebSocket when resuming app from a paused state ([#5567](#5567)) Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#5041
Description of changes:
Added an app life cycle stream/listener to reconnect API web sockets after the app is paused and resumed.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.