Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): multi bucket upload file #5600

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

Equartey
Copy link
Member

Description of changes:

  • Updates StorageUploadFileOptions to have a optional bucket param to specify target for operation
  • Updates S3 impl to use bucket param
  • Adds E2E tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Equartey Equartey requested a review from a team as a code owner October 24, 2024 17:36
@Equartey Equartey force-pushed the feat/multi-bucket-upload-file branch from 7e373fd to caa0daf Compare October 25, 2024 18:12
@Equartey Equartey force-pushed the feat/multi-bucket-upload-file branch from caa0daf to 530140a Compare October 28, 2024 20:02
Copy link
Member

@NikaHsn NikaHsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Equartey Equartey merged commit 4848d02 into multi-bucket Oct 29, 2024
155 checks passed
@Equartey Equartey deleted the feat/multi-bucket-upload-file branch October 29, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants