Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics dev #101

Merged
merged 23 commits into from
Jan 8, 2018
Merged

Analytics dev #101

merged 23 commits into from
Jan 8, 2018

Conversation

powerful23
Copy link
Contributor

@powerful23 powerful23 commented Dec 22, 2017

Remove Mobile Analytics SDK dependency.

@codecov-io
Copy link

codecov-io commented Dec 22, 2017

Codecov Report

Merging #101 into master will decrease coverage by <.01%.
The diff coverage is 87.01%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
- Coverage   92.03%   92.03%   -0.01%     
==========================================
  Files          51       51              
  Lines        2260     2297      +37     
  Branches      454      456       +2     
==========================================
+ Hits         2080     2114      +34     
- Misses        171      174       +3     
  Partials        9        9
Impacted Files Coverage Δ
packages/aws-amplify/src/Auth/Auth.ts 97.14% <ø> (ø) ⬆️
packages/aws-amplify/src/Cache/StorageCache.ts 79.16% <100%> (ø) ⬆️
packages/aws-amplify/src/Common/Facet.ts 100% <100%> (ø) ⬆️
packages/aws-amplify/src/Analytics/Analytics.ts 87.5% <86.48%> (+1.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b9bf02...ce856bf. Read the comment docs.

@mlabieniec mlabieniec mentioned this pull request Jan 7, 2018
Copy link
Contributor

@richardzcode richardzcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@powerful23 powerful23 merged commit e9f2e86 into aws-amplify:master Jan 8, 2018
@powerful23 powerful23 deleted the analytics_dev branch February 8, 2018 19:29
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants