Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update sdk client patch versions for fast-xml-parser security update #11489

Merged
merged 3 commits into from
Jun 14, 2023

Conversation

Samaritan1011001
Copy link
Member

Description of changes

Update the SDK patch versions to reflect it's internal upgrade to fast-xml-parser version 4.2.4

Issue #, if available

Description of how you validated changes

npm ls fast-xml-parser includes only fast-xml-parser version 4.2.4

amplify-js
├─┬ @aws-amplify/geo@2.0.34 -> ./packages/geo
│ └─┬ @aws-sdk/client-location@3.186.2
│   └─┬ @aws-sdk/client-sts@3.186.2
│     └── fast-xml-parser@4.2.4 deduped
└─┬ @aws-amplify/storage@5.4.0 -> ./packages/storage
  └─┬ @aws-sdk/client-s3@3.6.3
    └── fast-xml-parser@4.2.4

AND yarn test passes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Samaritan1011001 Samaritan1011001 requested review from a team as code owners June 12, 2023 23:22
wlee221
wlee221 approved these changes Jun 13, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #11489 (7b56262) into main (08fc7ee) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main   #11489   +/-   ##
=======================================
  Coverage   83.23%   83.23%           
=======================================
  Files         274      274           
  Lines       20523    20523           
  Branches     4436     4436           
=======================================
  Hits        17083    17083           
  Misses       3152     3152           
  Partials      288      288           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@stocaaro stocaaro merged commit 3d17208 into main Jun 14, 2023
@HuiSF HuiSF deleted the fix/fast-xml-parser-aws-sdk branch September 27, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants