-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(data): add custom primary key and related model tests #11836
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #11836 +/- ##
=======================================
Coverage 83.65% 83.65%
=======================================
Files 341 341
Lines 21579 21579
Branches 4611 4611
=======================================
Hits 18051 18051
Misses 3241 3241
Partials 287 287 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
b9ff204
to
7dea448
Compare
@@ -9,6 +9,8 @@ on: | |||
push: | |||
branches: | |||
- feat/example-integ-test-branch/main | |||
# TODO: remove before merging PR - added for test run prior to merge | |||
- cpk-related-models |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description of changes
Successful test run of new E2E tests
DataStore custom primary key E2E tests were recently disabled due to test flakiness after migrating to GitHub Actions. Our existing related model tests have sufficient overlap with CPK tests, so we were able to perform the update without significant loss of test coverage.
This PR adds test configuration to use the new custom primary key + related models sample app. The new sample app is a fork of the existing related model app, with the inclusion of the following missing test cases:
Once this PR has been merged I will remove existing sample apps + tests for both custom primary keys and related models.
Issue #, if available
Description of how you validated changes
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.