Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid federated signin redirect loop #11847

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

erinleigh90
Copy link
Member

Description of changes

Made sure urlListener is registered on Auth instance so the oAuthFlowInProgress refers to the Auth instance that customers are using.

  • NOTE: this will be an issue for UI team when they start using InternalAuth, so a more robust solution will need to be found going forward.

Issue #, if available

#11846

Description of how you validated changes

Reproduced issue in sample app, validated changes using yarn linking.

Checklist

  • PR description included
  • yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@erinleigh90 erinleigh90 requested a review from a team as a code owner August 21, 2023 19:52
Copy link
Contributor

@kvramyasri7 kvramyasri7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the Quick Fix Erin

@codecov-commenter
Copy link

Codecov Report

Merging #11847 (56c770b) into main (471cf2a) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main   #11847      +/-   ##
==========================================
+ Coverage   84.08%   84.12%   +0.04%     
==========================================
  Files         350      350              
  Lines       21172    21172              
  Branches     4452     4452              
==========================================
+ Hits        17803    17812       +9     
+ Misses       3108     3099       -9     
  Partials      261      261              
Files Changed Coverage Δ
packages/auth/src/internals/InternalAuth.ts 88.44% <100.00%> (+0.30%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kvramyasri7 kvramyasri7 merged commit 47d38f4 into aws-amplify:main Aug 21, 2023
29 checks passed
stocaaro added a commit that referenced this pull request Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants