Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor to avoid importing from current index #12636

Merged

Conversation

cshfang
Copy link
Member

@cshfang cshfang commented Nov 28, 2023

Description of changes

This PR updates import paths which reference index files within the current directory via the relative '.' path to avoid doing so. Babel module resolvers configured with root: ['.'] are unable to resolve this path correctly.

Issue #, if available

#12622

Description of how you validated changes

Tested locally with an React Native app with the above configuration to verify that changes resolved issue.

Checklist

  • PR description included
  • yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cshfang cshfang requested a review from a team as a code owner November 28, 2023 00:01
Copy link
Contributor

@elorzafe elorzafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@cshfang cshfang merged commit a353e0d into aws-amplify:main Nov 28, 2023
31 checks passed
@cshfang cshfang deleted the fix/avoid-importing-from-current-index branch November 28, 2023 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants