-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): expose generateClient from /server subpath #12691
Conversation
5254f51
to
12176ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just moved this file, no new changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This files is the test for the newly added generateClient
that's exported from api/serevr
. Please ignore the diff, and review the file itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit but LGTM
12176ae
to
54c8184
Compare
Description of changes
Exposed the
generateClient
from the subpathaws-amplify/api/server
to support use cases with the generic SSR framework adapterrunWithAmplifyServerContext
exported from the subpathaws-amplify/adapter-core
This PR includes all relevant changes.
Issue #, if available
Supporting: aws-amplify/docs#6591
Description of how you validated changes
adapter-nextjs
originallygenerateClient
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.