-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Multi-level item in selectionSet is not received #12701
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution! The PR looks good overall. I suggested a couple of changes to get the build passing.
Make `modelName` param in `dotNotationToObject` function required Co-authored-by: Ivan Artemiev <29709626+iartemiev@users.noreply.github.com>
Assert `relatedModel` as `ModelFieldType['model']` in `dotNotationToObject` function Co-authored-by: Ivan Artemiev <29709626+iartemiev@users.noreply.github.com>
@erickriva - bundle size check failed. I just pushed up a commit increasing the limit for this package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'm 98% there. I'm just a little confused on one point around the recursive merge at the moment.
I've also included a suggested docstring, but this was done in passing. It's a nit, largely written so I could summarize what I was looking at.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking on the prototype pollution issue discovered by CodeQL
@erickriva the prototype pollution mitigation looks good! The only apparent remaining blocker is a minor lint error:
You can verify locally by running |
Fixed lint error Co-authored-by: Ivan Artemiev <29709626+iartemiev@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thank-you!
@erickriva - PR has been merged. Thank you again for contributing! |
Fix for issue #12665