Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(repo): update badges in README #12704

Merged
merged 1 commit into from
Dec 14, 2023
Merged

chore(repo): update badges in README #12704

merged 1 commit into from
Dec 14, 2023

Conversation

HuiSF
Copy link
Member

@HuiSF HuiSF commented Dec 14, 2023

Description of changes

  • Removed lgtm badage (the service has shut down in 2022)
    • Can use Github analysis flow but requires a separate set up
  • Replaced Circle CI build badge with the main branch GH action workflow status
  • Replace HTML wit the markdown syntax

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@HuiSF HuiSF requested a review from a team as a code owner December 14, 2023 02:57
kvramyasri7
kvramyasri7 approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@kvramyasri7 kvramyasri7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

READIT. LGTM.

nadetastic
nadetastic approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@nadetastic nadetastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@HuiSF HuiSF merged commit a6a413c into main Dec 14, 2023
31 checks passed
@HuiSF HuiSF deleted the hui/chore/repo/replace-lgtm branch December 14, 2023 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwinkumar6 ashwinkumar6 ashwinkumar6 approved these changes

@kvramyasri7 kvramyasri7 kvramyasri7 approved these changes

@nadetastic nadetastic nadetastic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HuiSF @ashwinkumar6 @kvramyasri7 @nadetastic