-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(repo): update eslint ignore rule to be specific to packages #13010
Conversation
if (this.authOptions?.credentialsProvider) { | ||
return await this.authOptions.credentialsProvider.clearCredentialsAndIdentityId(); | ||
} | ||
await this.authOptions?.credentialsProvider?.clearCredentialsAndIdentityId(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I prefer the old version. Its more explicit and easily readable :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I prefer the latest as the new/upgraded versions includes security patches. But thanks for the suggestion will keep in mind.
|
||
function assertUserPoolAndIdentityPoolConfig( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this have been removed or properly used somewhere? I see its un used at the moment.
Description of changes
core
package again to conform to the linter rules.Issue #, if available
Description of how you validated changes
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.