Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data): tests for error response fix #13279

Merged
merged 10 commits into from
Apr 24, 2024
Merged

fix(data): tests for error response fix #13279

merged 10 commits into from
Apr 24, 2024

Conversation

david-mcafee
Copy link
Contributor

@david-mcafee david-mcafee commented Apr 22, 2024

Description of changes

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@david-mcafee david-mcafee marked this pull request as ready for review April 23, 2024 15:59
@david-mcafee david-mcafee requested a review from a team as a code owner April 23, 2024 15:59
Copy link
Member

@HuiSF HuiSF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicking comments 👍

@david-mcafee david-mcafee requested a review from a team as a code owner April 24, 2024 15:24
@david-mcafee david-mcafee requested a review from a team as a code owner April 24, 2024 16:26
@iartemiev iartemiev merged commit 1aef1ee into main Apr 24, 2024
31 checks passed
@HuiSF HuiSF deleted the error-responses-tests branch April 24, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants