fix: Prevent creating multiple endpoint ids #13319
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Currently, when an endpoint is created by
updateEndpoint
, it is not cached until a full network round trip to the service. This results in a large window during which additionalupdateEndpoint
calls will create new endpoint ids due to none being found in the cache.This PR adds a utility which will hold created endpoint ids in memory until it is successfully cached or if the endpoint updating has failed.
Issue #, if available
#13272
Description of how you validated changes
yarn test
updateEndpoint
function is the same (async void which throws uncaught)updateEndpoint
calls triggered byinitializePushNotifications
and an adjacentidentifyUser
call were no longer creating separate endpoints.Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.