Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release(required): an expired token that has valid signature is not considered a valid token #13464

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

HuiSF
Copy link
Member

@HuiSF HuiSF commented Jun 5, 2024

Description of changes

When a token has valid signature but expired, it should be considered a valid token.

Issue #, if available

#13456

Description of how you validated changes

  • Next.js sample app testing

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@HuiSF HuiSF requested a review from a team as a code owner June 5, 2024 18:51
@HuiSF HuiSF changed the base branch from main to release June 5, 2024 18:59
@HuiSF HuiSF marked this pull request as draft June 5, 2024 19:18
@HuiSF HuiSF marked this pull request as draft June 5, 2024 19:18
@HuiSF HuiSF marked this pull request as draft June 5, 2024 19:18
@HuiSF HuiSF force-pushed the hui/fix/adapter-nextjs/token-refresh branch from 6eadba2 to fbed395 Compare June 7, 2024 17:22
@HuiSF HuiSF marked this pull request as ready for review June 7, 2024 17:23
@HuiSF HuiSF changed the title fix(adapter-nextjs): an expired token that has valid signature is not considered a valid token release(required): an expired token that has valid signature is not considered a valid token Jun 7, 2024
@HuiSF HuiSF merged commit e12a280 into release Jun 7, 2024
28 checks passed
@HuiSF HuiSF deleted the hui/fix/adapter-nextjs/token-refresh branch June 10, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants