Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Refactor Storage Options #13613

Merged
merged 6 commits into from
Sep 24, 2024

Conversation

ashika112
Copy link
Member

@ashika112 ashika112 commented Jul 18, 2024

Description of changes

During Gen2 storage work we made some changes to naming convention for types WithKey and WithPath. Seems like we missed to update a bunch of internal storage options type. This PR updates the types name.

  • Also removes an unused s3 exception file

Note: All types updated are purely internal, no change to any external APIs

Description of how you validated changes

  • unit tests

Checklist

  • PR description included
  • yarn test passes
  • Unit Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ashika112 ashika112 marked this pull request as ready for review September 11, 2024 18:57
Copy link
Contributor

@jimblanc jimblanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@ashika112 ashika112 merged commit bcc3cbc into aws-amplify:main Sep 24, 2024
30 checks passed
@ashika112 ashika112 deleted the chore/storage-options-refactor branch September 24, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants