Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fixed cache.clear() not working as expected #13926

Merged
merged 4 commits into from
Oct 16, 2024

Conversation

yuhengshs
Copy link
Contributor

Description of changes

The purpose of this PR is to fix the issue that Cache.clear() is not working as expected by not clearing the cache.

  • Added prefix to the key to make sure the item is successfully identified and removed.
  • Updated the unit test to prevent missing prefix and not clearing cache

Issue #, if available

13791

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Unit Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@yuhengshs yuhengshs changed the title fix(Core): fixed cache.clear() not working as expected fix(core): fixed cache.clear() not working as expected Oct 15, 2024
@yuhengshs yuhengshs marked this pull request as ready for review October 15, 2024 21:35
@yuhengshs yuhengshs requested review from a team as code owners October 15, 2024 21:35
ashika112
ashika112 previously approved these changes Oct 16, 2024
@yuhengshs yuhengshs merged commit 60de524 into main Oct 16, 2024
30 checks passed
@yuhengshs yuhengshs deleted the fix/cache-clear-not-working branch October 16, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants