React sign out #191
React sign out #191
Conversation
Codecov Report
@@ Coverage Diff @@
## master #191 +/- ##
==========================================
- Coverage 90.97% 89.67% -1.31%
==========================================
Files 59 59
Lines 2882 2964 +82
Branches 572 587 +15
==========================================
+ Hits 2622 2658 +36
- Misses 246 292 +46
Partials 14 14
Continue to review full report at Codecov.
|
| @@ -46,11 +48,51 @@ export default class Greetings extends AuthPiece { | |||
| } | |||
|
|
|||
| signOut() { | |||
| this.googleSignOut(); | |||
There was a problem hiding this comment.
We do some sort of check here first before calling these so we don't run into unexpected exceptions with the specific frameworks. Perhaps we should abstract this out into the Auth.signOut() method as well, so the error returned in catch() could be related to federated.
There was a problem hiding this comment.
Check is implemented in the beginning of those methods.
| Auth.signOut() | ||
| .then(() => this.changeState('signedOut')) | ||
| .catch(err => { logger.error(err); this.error(err); }); | ||
| } | ||
|
|
||
| googleSignOut() { | ||
| const auth2 = window.gapi && window.gapi.auth2? window.gapi.auth2 : null; |
There was a problem hiding this comment.
update here to not include int in the string name, use something like authGoogle etc.
There was a problem hiding this comment.
auth2 is a name given by Google.
| } | ||
|
|
||
| facebookSignOut() { | ||
| const fb = window.FB; |
There was a problem hiding this comment.
check if window.FB exists first
There was a problem hiding this comment.
Will be checked in the next line.
…plify into react-sign-out
| @@ -33,7 +34,7 @@ export default function withGoogle(Comp) { | |||
| }; | |||
|
|
|||
| const { onStateChange } = this.props; | |||
| return Auth.federatedSignIn('google', { token: id_token, expires_at }, user) | |||
| return Auth.federatedSignIn('google', { token: id_token, expires_at, refreshing: false }, user) | |||
| .then(crednetials => { | |||
There was a problem hiding this comment.
typo 'crednetials ' = credentials
| @@ -46,6 +46,7 @@ export default function withFacebook(Comp) { | |||
| if (!accessToken) { | |||
| return; | |||
| } | |||
| const that = this; | |||
| @@ -32,6 +32,7 @@ export default function withGoogle(Comp) { | |||
| name: profile.getName() | |||
| }; | |||
|
|
|||
| const that = this; | |||
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
For issue #180
Refreshing federated jwt token on need.