-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ml/react native #200
Ml/react native #200
Conversation
…into link-cognito-sdk
Codecov Report
@@ Coverage Diff @@
## master #200 +/- ##
==========================================
- Coverage 92.24% 90.92% -1.32%
==========================================
Files 52 53 +1
Lines 2424 2480 +56
Branches 486 501 +15
==========================================
+ Hits 2236 2255 +19
- Misses 179 215 +36
- Partials 9 10 +1
Continue to review full report at Codecov.
|
When calling API.get(), An error saying "Refused to set unsafe header "User-Agent" which may be caused by RestClient.ts line 79 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
* add cognito js lib and update references * update cognito lib * update node version and package deps * update cognito sdk and auth test * update with yarn workspaces and modules * add lint to test * update test cmd * update build cmds * update concurrency with bootstrap * update deps, yarn should use local * add build before test for workspaces * remove package-lock.json * update rn package * update deps on react native * update user attributes * update docs * core change * Update package.json * Adds a podspec for CocoaPods support * update docs with cli instructions * update quick start * update crypto lib for react native and polyfill methods * move core logic to aws-amplify * updates for platform detection * fixes for auth persistence * update user agent in RestClient to use Platform * update readme for PR aws-amplify#201 * only set user-agent on API calls in RN * Remove unused JS call for verifiedContact
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
This PR addresses many duplications of code across aws-amplify-react-native and aws-amplify. The core logic around Authentication, including persistence is now located within aws-amplify and included in aws-amplify-react-native. This also contains updates to the amazon-cognito-identity-js to utilize crypo libraries without the need of the requirement of the aws-sdk. All core logic now resides in aws-amplify, with a new Platform check on the navigator.product to determine if running in React Native (see: facebook/react-native#1331).