Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

picker, album fixes. protected level, cache-control header #213

Merged
merged 2 commits into from
Jan 31, 2018

Conversation

richardzcode
Copy link
Contributor

issue #60, #211, #212

@codecov-io
Copy link

codecov-io commented Jan 31, 2018

Codecov Report

Merging #213 into master will decrease coverage by 0.04%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #213      +/-   ##
==========================================
- Coverage   90.68%   90.64%   -0.05%     
==========================================
  Files          53       53              
  Lines        2502     2512      +10     
  Branches      506      510       +4     
==========================================
+ Hits         2269     2277       +8     
- Misses        223      224       +1     
- Partials       10       11       +1
Impacted Files Coverage Δ
packages/aws-amplify-react/src/Storage/S3Album.js 94.11% <100%> (+0.05%) ⬆️
packages/aws-amplify-react/src/Widget/Picker.js 100% <100%> (ø) ⬆️
packages/aws-amplify/src/Storage/Storage.ts 96% <81.81%> (-1.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e41c2c6...c449738. Read the comment docs.

Copy link
Contributor

@powerful23 powerful23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@richardzcode richardzcode merged commit 9563713 into aws-amplify:master Jan 31, 2018
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants