Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs #227

Merged
merged 7 commits into from
Feb 4, 2018
Merged

Update docs #227

merged 7 commits into from
Feb 4, 2018

Conversation

mlabieniec
Copy link
Contributor

@mlabieniec mlabieniec commented Feb 3, 2018 •
edited
Loading

@codecov-io
Copy link

codecov-io commented Feb 3, 2018 •
edited
Loading

Codecov Report

Merging #227 into master will decrease coverage by 0.03%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
- Coverage    90.8%   90.77%   -0.04%     
==========================================
  Files          53       53              
  Lines        2513     2515       +2     
  Branches      510      510              
==========================================
+ Hits         2282     2283       +1     
- Misses        220      221       +1     
  Partials       11       11
Impacted Files Coverage Δ
packages/aws-amplify/src/Auth/Auth.ts 89.44% <50%> (-0.46%) ⬇️
packages/aws-amplify/src/Common/index.ts 83.33% <0%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dedac2...5b45a11. Read the comment docs.

elorzafe
elorzafe suggested changes Feb 3, 2018
View reviewed changes
Copy link
Contributor

@elorzafe elorzafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs link is broken, maybe add more info about aws_exports. Like on other docs

docs/index.md Outdated

## Examples

AWS Amplify supports many category scenarios such as Auth, Analytics, APIs and Storage as outlined in the [Developer Guide](docs/media/developer_guide.md). A couple of samples are below.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link is broken, should remove docs/

docs/index.md
import Amplify, { Analytics } from 'aws-amplify';
import aws_exports from './aws-exports';

Amplify.configure(aws_exports);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add where to get aws_exports file? Like on the other docs.

@mlabieniec
Copy link
Contributor Author

@elorzafe updated

@mlabieniec
Copy link
Contributor Author

Updated to include Fix for #229

powerful23
powerful23 approved these changes Feb 4, 2018
View reviewed changes
Copy link
Contributor

@powerful23 powerful23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

mlabieniec
mlabieniec commented Feb 4, 2018
View reviewed changes
Copy link
Contributor Author

@mlabieniec mlabieniec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@mlabieniec mlabieniec merged commit 21c327c into aws-amplify:master Feb 4, 2018
@powerful23
Copy link
Contributor

also fixed issue #242

@powerful23 powerful23 mentioned this pull request Feb 6, 2018
Closed
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elorzafe elorzafe elorzafe requested changes

@powerful23 powerful23 powerful23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mlabieniec @codecov-io @powerful23 @elorzafe