-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs #227
Update docs #227
Conversation
mlabieniec
commented
Feb 3, 2018
•
edited
Loading
edited
- update docs index to include examples, Fixes Docs: Example links on blob/master/docs/index.md appear to be broken #226
Codecov Report
@@ Coverage Diff @@
## master #227 +/- ##
==========================================
- Coverage 90.8% 90.77% -0.04%
==========================================
Files 53 53
Lines 2513 2515 +2
Branches 510 510
==========================================
+ Hits 2282 2283 +1
- Misses 220 221 +1
Partials 11 11
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs link is broken, maybe add more info about aws_exports. Like on other docs
docs/index.md
Outdated
|
||
## Examples | ||
|
||
AWS Amplify supports many category scenarios such as Auth, Analytics, APIs and Storage as outlined in the [Developer Guide](docs/media/developer_guide.md). A couple of samples are below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link is broken, should remove docs/
import Amplify, { Analytics } from 'aws-amplify'; | ||
import aws_exports from './aws-exports'; | ||
|
||
Amplify.configure(aws_exports); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add where to get aws_exports file? Like on the other docs.
@elorzafe updated |
Updated to include Fix for #229 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
also fixed issue #242 |
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |