-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Span Tag around '*' for Required Input Fields #4165
Conversation
The 'span' tag allows for custom styling of required flag.
Codecov Report
@@ Coverage Diff @@
## master #4165 +/- ##
=======================================
Coverage 78.72% 78.72%
=======================================
Files 165 165
Lines 9032 9032
Branches 1872 1820 -52
=======================================
Hits 7110 7110
- Misses 1783 1789 +6
+ Partials 139 133 -6
Continue to review full report at Codecov.
|
@haverchuck this is a small UI enhancement to keep things consistent with signup form. It will allow for customizing the styles of required fields. |
Hey @sam-nasb, thank you for contributing! This change looks good but unfortunately it would break anyone using the i18n utility for translating the english words and statements changed in this PR. We can roll this into our UI component refactor highlighted in this RFC. This breaking change will need to be made to achieve consistency between the frontend frameworks that we support. If you would like, you can open a new issue with the use case required and we can track it for the release of the UI component refactor. |
@jordanranz, thank you for checking the code and your kind words. |
@sam-nasb, since this feature is already built into the UI component refactor project, I'll go ahead and close this PR. Thank you again for contributing! |
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Issue #, if available:
Not available.
Description of changes:
The 'span' tag allows for custom styling of required flag. Also this makes it consistent with the signup form.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.