Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Span Tag around '*' for Required Input Fields #4165

Closed
wants to merge 2 commits into from

Conversation

selkhateeb
Copy link

Issue #, if available:
Not available.
Description of changes:
The 'span' tag allows for custom styling of required flag. Also this makes it consistent with the signup form.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

The 'span' tag allows for custom styling of required flag.
@codecov
Copy link

codecov bot commented Oct 10, 2019

Codecov Report

Merging #4165 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4165   +/-   ##
=======================================
  Coverage   78.72%   78.72%           
=======================================
  Files         165      165           
  Lines        9032     9032           
  Branches     1872     1820   -52     
=======================================
  Hits         7110     7110           
- Misses       1783     1789    +6     
+ Partials      139      133    -6
Impacted Files Coverage Δ
packages/core/src/OAuthHelper/GoogleOAuth.ts 31.25% <0%> (ø) ⬆️
...ackages/pubsub/src/Providers/AWSAppSyncProvider.ts 66.66% <0%> (ø) ⬆️
...rc/Providers/AmazonAIConvertPredictionsProvider.ts 61.23% <0%> (ø) ⬆️
packages/xr/src/Providers/SumerianProvider.ts 47.55% <0%> (ø) ⬆️
packages/core/src/OAuthHelper/FacebookOAuth.ts 34.09% <0%> (ø) ⬆️
packages/auth/src/OAuth/OAuth.ts 48.48% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f37cff7...ce6f293. Read the comment docs.

@sam-nasb
Copy link

@haverchuck this is a small UI enhancement to keep things consistent with signup form. It will allow for customizing the styles of required fields.
What's it going to take to get you to take a look at it?

@jordanranz
Copy link
Contributor

Hey @sam-nasb, thank you for contributing!

This change looks good but unfortunately it would break anyone using the i18n utility for translating the english words and statements changed in this PR.

We can roll this into our UI component refactor highlighted in this RFC. This breaking change will need to be made to achieve consistency between the frontend frameworks that we support.

If you would like, you can open a new issue with the use case required and we can track it for the release of the UI component refactor.

@jordanranz jordanranz added feature-request Request a new feature UI Related to UI Components labels Dec 30, 2019
@sam-nasb
Copy link

sam-nasb commented Jan 2, 2020

@jordanranz, thank you for checking the code and your kind words.
The company changed direction on using this and I don't have a use case for it anymore. Feel free to close the PR if you don't think you have a need for it.
I appreciate you looking into it.

@jordanranz
Copy link
Contributor

@sam-nasb, since this feature is already built into the UI component refactor project, I'll go ahead and close this PR. Thank you again for contributing!

@jordanranz jordanranz closed this Jan 2, 2020
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request a new feature UI Related to UI Components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants