Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customize endpointId #421

Merged
merged 3 commits into from
Mar 9, 2018

Conversation

powerful23
Copy link
Contributor

Issue #, if available:
Enable users to customize the endpoint id in Analytics
Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Mar 8, 2018

Codecov Report

Merging #421 into master will decrease coverage by 0.03%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #421      +/-   ##
==========================================
- Coverage   91.29%   91.26%   -0.04%     
==========================================
  Files          56       56              
  Lines        2687     2689       +2     
  Branches      538      538              
==========================================
+ Hits         2453     2454       +1     
- Misses        222      223       +1     
  Partials       12       12
Impacted Files Coverage Δ
packages/aws-amplify/src/Analytics/Analytics.ts 94.11% <100%> (+0.07%) ⬆️
...fy/src/Analytics/Providers/AWSAnalyticsProvider.ts 97.2% <50%> (-0.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6154ee3...cdd6920. Read the comment docs.

Copy link
Contributor

@mlabieniec mlabieniec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@powerful23 powerful23 merged commit 7682bbc into aws-amplify:master Mar 9, 2018
@powerful23 powerful23 deleted the customize-endpoint-id branch March 19, 2018 22:25
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants