Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for developer authenticated strategies #425

Merged
merged 1 commit into from
Mar 9, 2018
Merged

Add support for developer authenticated strategies #425

merged 1 commit into from
Mar 9, 2018

Conversation

buggy
Copy link
Contributor

@buggy buggy commented Mar 9, 2018

Issue #, if available:

#308 and #416

Description of changes:

This PR add developer to the list of domainssetCredentialsFromFederation() will accept credentials for. After this change you sign in using developer authenticated credentials from a Cognito Identity Pool with federatedSignIn() by passing developer as the provider.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

Codecov Report

Merging #425 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #425   +/-   ##
=======================================
  Coverage   91.29%   91.29%           
=======================================
  Files          56       56           
  Lines        2687     2687           
  Branches      538      538           
=======================================
  Hits         2453     2453           
  Misses        222      222           
  Partials       12       12
Impacted Files Coverage Δ
packages/aws-amplify/src/Auth/Auth.ts 90.78% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 605dc07...b452534. Read the comment docs.

@mlabieniec mlabieniec merged commit c09f60b into aws-amplify:master Mar 9, 2018
@buggy buggy deleted the feature/developer-authenticated branch March 9, 2018 23:04
@nminchowNelnet
Copy link

@buggy - would it be possible to get some more info on how this is supposed to work? Whenever I call federatedSignIn() like so:

Auth.federatedSignIn(
  'developer',
  {
      // The token I get back from 'GetOpenIdTokenForDeveloper'
      token: "eyJr(...)",
  }
)

I get the following 400 back when the call to "https://cognito-identity.us-east-2.amazonaws.com/" is made: Error: Invalid login token. Can't pass in a Cognito token.

I think these changes may fix my issue: #562, but I'm curious how this works without them.

@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants