Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binding console to console functions #458

Merged
merged 1 commit into from
Mar 15, 2018
Merged

Binding console to console functions #458

merged 1 commit into from
Mar 15, 2018

Conversation

vipseixas
Copy link
Contributor

Issue #451

Using bind() to ensure that console.[log|warn|error] works in any environment.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@richardzcode
Copy link
Contributor

Looks good. 👍

Copy link
Contributor

@richardzcode richardzcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-io
Copy link

Codecov Report

Merging #458 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #458   +/-   ##
=======================================
  Coverage   90.97%   90.97%           
=======================================
  Files          59       59           
  Lines        2882     2882           
  Branches      572      572           
=======================================
  Hits         2622     2622           
  Misses        246      246           
  Partials       14       14
Impacted Files Coverage Δ
...ges/aws-amplify/src/Common/Logger/ConsoleLogger.ts 81.25% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a365435...97855d5. Read the comment docs.

@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants