Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics turn on off #479

Merged
merged 8 commits into from
Mar 22, 2018

Conversation

powerful23
Copy link
Contributor

Issue #, if available:

Description of changes:
To give the ability to turn on/off Analytics module

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Mar 20, 2018

Codecov Report

Merging #479 into master will decrease coverage by 0.13%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #479      +/-   ##
==========================================
- Coverage   89.68%   89.55%   -0.14%     
==========================================
  Files          59       59              
  Lines        2977     2987      +10     
  Branches      589      591       +2     
==========================================
+ Hits         2670     2675       +5     
- Misses        292      297       +5     
  Partials       15       15
Impacted Files Coverage Δ
packages/aws-amplify/src/Analytics/Analytics.ts 89.47% <50%> (-4.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02aa4f7...1ddfffa. Read the comment docs.

Copy link
Contributor

@richardzcode richardzcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@powerful23 powerful23 merged commit a7d7aeb into aws-amplify:master Mar 22, 2018
@powerful23 powerful23 deleted the analytics-turn-on-off branch March 29, 2018 19:08
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants