Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Storage operations options optional #527

Merged
merged 3 commits into from
Mar 27, 2018

Conversation

powerful23
Copy link
Contributor

Issue #, if available:
For typescript error #422
Description of changes:
To make options optional when using typescript

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Mar 26, 2018

Codecov Report

Merging #527 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #527   +/-   ##
=======================================
  Coverage   88.89%   88.89%           
=======================================
  Files          62       62           
  Lines        3063     3063           
  Branches      592      591    -1     
=======================================
  Hits         2723     2723           
  Misses        325      325           
  Partials       15       15
Impacted Files Coverage Δ
packages/aws-amplify/src/Storage/Storage.ts 96.09% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfca2ee...f47f29a. Read the comment docs.

Copy link
Contributor

@mlabieniec mlabieniec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@powerful23 powerful23 merged commit ec7101e into aws-amplify:master Mar 27, 2018
@powerful23 powerful23 deleted the for-issue-422 branch April 25, 2018 20:28
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants