Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard dismiss fix #530

Merged
merged 3 commits into from
Apr 9, 2018

Conversation

powerful23
Copy link
Contributor

Issue #, if available:
For issue #491
Description of changes:
Enable to dismiss keyboard for react native

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@richardzcode richardzcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@07922bd). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #530   +/-   ##
=========================================
  Coverage          ?   89.19%           
=========================================
  Files             ?       69           
  Lines             ?     3221           
  Branches          ?      612           
=========================================
  Hits              ?     2873           
  Misses            ?      330           
  Partials          ?       18

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07922bd...80cc7df. Read the comment docs.

@richardzcode richardzcode merged commit 49d91e7 into aws-amplify:master Apr 9, 2018
@powerful23
Copy link
Contributor Author

@lepirlouit thanks for your feedback. I created a pr #1325 to fix this issue.

@lepirlouit
Copy link

Thanks, for your quick reaction on this.

@powerful23 powerful23 deleted the keyboard-dismiss-fix branch August 15, 2018 17:47
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants