Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth current user info fix #608

Merged
merged 3 commits into from
Apr 7, 2018

Conversation

powerful23
Copy link
Contributor

@powerful23 powerful23 commented Apr 6, 2018

Issue #, if available:
#592
Description of changes:
Fix the problem when using Auth.currentUserInfo() in the componentDidMount will return empty object

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Apr 6, 2018

Codecov Report

Merging #608 into master will decrease coverage by 0.07%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #608      +/-   ##
==========================================
- Coverage   89.27%   89.19%   -0.08%     
==========================================
  Files          69       69              
  Lines        3217     3221       +4     
  Branches      611      612       +1     
==========================================
+ Hits         2872     2873       +1     
- Misses        328      330       +2     
- Partials       17       18       +1
Impacted Files Coverage Δ
packages/aws-amplify/src/Auth/Auth.ts 84.71% <25%> (-0.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a1428d...3093bfd. Read the comment docs.

Copy link
Contributor

@mlabieniec mlabieniec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@powerful23 powerful23 merged commit 0cee8db into aws-amplify:master Apr 7, 2018
@fahrenq
Copy link

fahrenq commented Apr 10, 2018

Hi @mlabieniec! Can you please tell me, if you know when this change will be released? It's really important.

Thank you!

@richardzcode
Copy link
Contributor

@fahrenq we are working on a release.

@powerful23 powerful23 deleted the auth-currentUserInfo-fix branch April 25, 2018 20:26
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants