fix(@aws-amplify/auth): Default hash to # when null
#6279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericclemmons
changed the title
null, so default to # to prevent errors# when null
Codecov Report
@@ Coverage Diff @@
## main #6279 +/- ##
=======================================
Coverage 73.26% 73.26%
=======================================
Files 208 208
Lines 12920 12920
Branches 2524 2525 +1
=======================================
Hits 9466 9466
Misses 3263 3263
Partials 191 191
Continue to review full report at Codecov.
|
|
Can we get this fix in, please? It's breaking my app at the moment. |
nubpro
pushed a commit
to nubpro/amplify-js
that referenced
this pull request
Oct 2, 2020
iartemiev
pushed a commit
that referenced
this pull request
Oct 13, 2020
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Fixes #6059
Description of changes:
When a URL doesn't contain
#...,parse(url)returns{ hash: null }, which creates a run-time error forhash.substr(1).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.