Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cypress 'included' image in CircleCi for Cypress 4.12.1 #6639

Merged
merged 3 commits into from
Aug 24, 2020

Conversation

jordanranz
Copy link
Contributor

@jordanranz jordanranz commented Aug 24, 2020

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jordanranz jordanranz marked this pull request as ready for review August 24, 2020 22:12
@jordanranz jordanranz requested a review from iartemiev as a code owner August 24, 2020 22:12
@jordanranz jordanranz changed the title Use cypress browser image in CircleCi Use cypress 'included' image in CircleCi for Cypress 4.12.1 Aug 24, 2020
Copy link
Member

@iartemiev iartemiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@jordanranz jordanranz merged commit 18d3182 into aws-amplify:main Aug 24, 2020
nubpro pushed a commit to nubpro/amplify-js that referenced this pull request Oct 2, 2020
…ify#6639)

* Use cypress browser image in CircleCi

* Use 'included' cypress image for Cypress 4.12.1

Co-authored-by: Ivan Artemiev <29709626+iartemiev@users.noreply.github.com>
iartemiev added a commit that referenced this pull request Oct 13, 2020
* Use cypress browser image in CircleCi

* Use 'included' cypress image for Cypress 4.12.1

Co-authored-by: Ivan Artemiev <29709626+iartemiev@users.noreply.github.com>
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants