Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@aws-amplify/auth): Fix types for completeNewPassword #6657

Merged
merged 2 commits into from
Aug 26, 2020

Conversation

elorzafe
Copy link
Contributor

Issue #, if available:
Fixes: #6634
Description of changes:
Adding default argument for requiredAttributes for Auth.completeNewPassword API
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Aug 26, 2020

Codecov Report

Merging #6657 into main will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6657   +/-   ##
=======================================
  Coverage   73.23%   73.23%           
=======================================
  Files         208      208           
  Lines       12941    12942    +1     
  Branches     2436     2530   +94     
=======================================
+ Hits         9477     9478    +1     
+ Misses       3301     3272   -29     
- Partials      163      192   +29     
Impacted Files Coverage Δ
packages/auth/src/Auth.ts 86.41% <100.00%> (+0.01%) ⬆️
packages/auth/src/OAuth/OAuth.ts 56.11% <0.00%> (ø)
packages/core/src/Credentials.ts 29.91% <0.00%> (ø)
packages/analytics/src/Analytics.ts 64.81% <0.00%> (ø)
packages/datastore/src/sync/index.ts 15.38% <0.00%> (ø)
packages/datastore/src/sync/outbox.ts 24.48% <0.00%> (ø)
packages/datastore/src/storage/storage.ts 71.66% <0.00%> (ø)
packages/core/src/OAuthHelper/GoogleOAuth.ts 33.33% <0.00%> (ø)
packages/core/src/Util/Reachability.native.ts 37.50% <0.00%> (ø)
packages/xr/src/Providers/SumerianProvider.ts 47.55% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85cb5ca...09114d9. Read the comment docs.

Copy link
Contributor

@sammartinez sammartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌮

@elorzafe elorzafe merged commit 84af018 into aws-amplify:main Aug 26, 2020
@elorzafe elorzafe deleted the auth/complete-new-password branch August 26, 2020 16:08
nubpro pushed a commit to nubpro/amplify-js that referenced this pull request Oct 2, 2020
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CompleteNewPassword requiredAttributes is not optional
3 participants