Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datastore): support IndexedDB Adapter on web worker #6874

Merged
merged 1 commit into from
Sep 26, 2020
Merged

feat(datastore): support IndexedDB Adapter on web worker #6874

merged 1 commit into from
Sep 26, 2020

Conversation

tlikits
Copy link
Contributor

@tlikits tlikits commented Sep 25, 2020

Issue #, if available:
#6870

Description of changes:

  • Add isWebWorker function to @aws-amplify/core to check if running on web worker or not
  • Add isWebWorker condition in DataStore getDefaultAdapter

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Sep 25, 2020

Codecov Report

Merging #6874 into main will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6874      +/-   ##
==========================================
- Coverage   73.35%   73.34%   -0.02%     
==========================================
  Files         213      213              
  Lines       13153    13159       +6     
  Branches     2470     2568      +98     
==========================================
+ Hits         9649     9651       +2     
+ Misses       3340     3314      -26     
- Partials      164      194      +30     
Impacted Files Coverage Δ
packages/core/src/JS.ts 91.89% <33.33%> (-3.35%) ⬇️
...ore/src/storage/adapter/getDefaultAdapter/index.ts 75.00% <100.00%> (ø)
packages/auth/src/OAuth/OAuth.ts 56.11% <0.00%> (ø)
packages/core/src/Credentials.ts 31.51% <0.00%> (ø)
packages/analytics/src/Analytics.ts 63.58% <0.00%> (ø)
packages/datastore/src/sync/index.ts 15.41% <0.00%> (ø)
packages/datastore/src/sync/outbox.ts 24.00% <0.00%> (ø)
packages/datastore/src/storage/storage.ts 71.66% <0.00%> (ø)
packages/core/src/OAuthHelper/GoogleOAuth.ts 33.33% <0.00%> (ø)
packages/core/src/Util/Reachability.native.ts 37.50% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cc5587...c2ee67c. Read the comment docs.

Copy link
Member

@iartemiev iartemiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you, @wylfent

@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants